Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add pr test and lint #165

Merged
merged 1 commit into from
Feb 6, 2024
Merged

ci: add pr test and lint #165

merged 1 commit into from
Feb 6, 2024

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Feb 5, 2024

  • .github/workflows/ci.yml
    • Run test and linter on pull request.
  • .github/workflows/semantic-pr.yml
    • Add semantic check
  • lib/web/amplitude_js.dart
    • Not sure if changing to camel case will break it so ignore lint rule for these two
  • example/*.*,
    • fix current lint errors by dart fix --apply
> flutter analyze                                                                                                                                                                                                                                                           ─╯
Analyzing Amplitude-Flutter...                                          

   info • The import of 'package:flutter/foundation.dart' is unnecessary because all of the used elements are also provided by the import of 'package:flutter/material.dart' • example/lib/app_state.dart:2:8 • unnecessary_import
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/deviceid_sessionid.dart:16:66 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/deviceid_sessionid.dart:31:67 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/event_form.dart:25:58 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/flush_thresholds_form.dart:42:68 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/group_form.dart:32:68 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/group_identify_form.dart:44:67 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/identify_form.dart:38:61 • deprecated_member_use
   info • 'bodyText1' is deprecated and shouldn't be used. Use bodyLarge instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/my_app.dart:115:67 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/revenue_form.dart:41:60 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/user_id_form.dart:22:68 • deprecated_member_use
   info • 'headline5' is deprecated and shouldn't be used. Use headlineSmall instead. This feature was deprecated after v3.1.0-0.0.pre • example/lib/user_id_form.dart:30:60 • deprecated_member_use
   info • The variable name 'opt_callback' isn't a lowerCamelCase identifier • lib/web/amplitude_js.dart:41:17 • non_constant_identifier_names
   info • The variable name 'opt_error_callback' isn't a lowerCamelCase identifier • lib/web/amplitude_js.dart:42:17 • non_constant_identifier_names

14 issues found. (ran in 1.0s)

@Mercy811 Mercy811 merged commit 233818d into v4.x Feb 6, 2024
2 checks passed
@Mercy811 Mercy811 deleted the AMP-93080-ci-Set-up-github-actions branch February 6, 2024 01:13
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@izaaz izaaz Awaiting requested review from izaaz

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mercy811 @justin-fiedler @qingzhuozhen